Correctly parse invalid numbers in JsonLiteral.long and other extensions #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content must be consumed fully, with no leftovers after number. Also simplify try/catching logic — JsonLiteral.long should throw NumberFormatException, while decoding from JsonElement should throw JsonDecodingException Fixes #2849
shanshin
reviewed
Nov 14, 2024
| val str = """{"a": "3 digit then random string"}""" | ||
| val obj = Json.decodeFromString<JsonObject>(str) | ||
| assertFailsWithMessage<NumberFormatException>("Expected input to contain a single valid number") { | ||
| println(obj.getValue("a").jsonPrimitive.long) |
There was a problem hiding this comment.
It'll throw exception before that anyway
| // Slow path, never called in normal code, can avoid optimizing it | ||
| val expected = tokenDescription(expectedToken) | ||
| val position = if (wasConsumed) currentPosition - 1 else currentPosition | ||
| val s = if (currentPosition == source.length || position < 0) "EOF" else source[position].toString() | ||
| fail("Expected $expected, but had '$s' instead", position) | ||
| fail(message(expected, s), position) |
There was a problem hiding this comment.
Is it expected to print in exception only first wrong character?
There was a problem hiding this comment.
Yes, because generally, we do not know where input ends (e.g. in the case of {"a": 12312:xdwadaw213123123413.....}, incorrect part may potentially be as long as whole source itself
| checkSerializationException({ | ||
| default.decodeFromString(OuterLong.serializer(), """{"a":"12:34:45"}""", mode) | ||
| }, { | ||
| if (mode == JsonTestingMode.TREE) assertContains(it, "Failed to parse literal '\"12:34:45\"' as a long value at element: \$.a") |
There was a problem hiding this comment.
Should we also check exception type?
There was a problem hiding this comment.
checkSerializationException makes sure that only SerializationExceptions are accepted
shanshin
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content must be consumed fully, with no leftovers after number. Also simplify try/catching logic — JsonLiteral.long should throw NumberFormatException, while decoding from JsonElement should throw JsonDecodingException
Fixes #2849