Generate unique Automatic-Module-Name for metadata JARs #3109
Conversation
| */ | ||
| fun Project.configureMetadataJarAutomaticModuleName() { | ||
| val kotlin = extensions.findByType<KotlinMultiplatformExtension>() ?: return | ||
| val moduleName = project.name.replace('-', '.') + ".artifact_disambiguating_module" |
There was a problem hiding this comment.
NB: Manifest lines are supposed to be 72 chars in length
No line may be longer than 72 bytes (not characters), in its UTF8-encoded form. If a value would make the initial line longer than this, it should be continued on extra lines (each starting with a single SPACE).
https://docs.oracle.com/en/java/javase/25/docs/specs/jar/jar.html
So this gets automatically wrapped to next line:
Manifest-Version: 1.0
Automatic-Module-Name: kotlinx.serialization.core.artifact_disambiguatin
g_module
While it shouldn't cause any problems, we may want to choose a shorter name to look a bit nicer. WDYT of common_artifact suffix?
There was a problem hiding this comment.
I picked the same name we agreed to use for coroutines for consistency.
I'm not sure if we should pursue shorter name here, as nobody is expected to import that module. And I hope not so many people have to read manifest files bundled in third-party libraries (to enjoy nice name :)).
If you prefer a shorter name, than kotlin_metadata or just metadata might be a better option compared to common_artifact.
There was a problem hiding this comment.
Let's stick to kotlinx.coroutines name then
Fixes #2901