Protobuf skip null fields #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the Bson format
No need for a String Array anymore in any of the new kotlin versions (since 1.3)
bezmax
force-pushed
the
protobuf-skip-null-fields
branch
from
5a178d0
to
6968ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #588
The issue blocks any real usage of kotlinx.serialization, as there is no way to serialize an optional field as of right now. I suggest this as an easy and mostly-compatible fix until a long-term solution is devised.
The solution here introduces separate
TaggedEncoder#shouldWriteNullElementmethod, which can be overriden by different Encoders to provide custom null-handling behaviour. For this PR only ProtoBufEncoder overrides it to skip null CLASS type fields (as should be completely compatible with Proto spec).Other encoders could also benefit from this, for example an extra setting could be added to JSON encoder to skip null fields altogether.