Introduce 'treatNullAsMissing' flag #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and implement it for streaming parser
fix error-prone test helper method Fix legacyJsIr tests that can't use serializer<T>()
qwwdfsad
requested changes
Jun 19, 2020
runtime/commonTest/src/kotlinx/serialization/json/JsonUseDefaultOnNullTest.kt
Outdated
Show resolved
Hide resolved
runtime/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonInput.kt
Outdated
Show resolved
Hide resolved
runtime/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonInput.kt
Show resolved
Hide resolved
sandwwraith
force-pushed
the
json_rollback
branch
from
6ae0562
to
6f9b36d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat
nullliterals in JSON as a missing value indicator, allowing parsing"x":nullto a non-nullablex: Boolean = falseIt also allows treating unknown enum values as missing ones, so this flag may need a better name; 'treatNullOrUnknownAsMissing' sounds long and cumbersome.
Closes #246 and #90 (only for json, though)