Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Dynamic parser/serializer with the rest of JSON #895

Merged
merged 6 commits into from
Jul 17, 2020
Merged

Unify Dynamic parser/serializer with the rest of JSON #895

merged 6 commits into from
Jul 17, 2020

Conversation

sandwwraith
Copy link
Member

@sandwwraith sandwwraith commented Jul 8, 2020 •
edited
Loading

  • Hide DynamicObjectParser/Serializer to internal package; Expose decodeFromDynamic/encodeToDynamic instead

@sandwwraith sandwwraith requested a review from qwwdfsad July 8, 2020 17:50
@sandwwraith
Hide DynamicObjectParser/Serializer to internal package
fa95fb2 
Expose decodeFromDynamic/encodeToDynamic instead
@sandwwraith
Introduce 'alwaysDropNulls' JSON flag.
3204448 
This flag forces encoder to always ignore nulls during serialization, which
may become irreversible if nullable property was not optional.
@sandwwraith
Remove default ctor args -- they're not needed anymore
636c223
@sandwwraith
Revert "Introduce 'alwaysDropNulls' JSON flag."
ea2c9e1 
This reverts commit f9302ce
@sandwwraith
~rebase fixup
2843202
@sandwwraith
Add serializersModule support to dynamic serializer
6e9a6ac
qwwdfsad
qwwdfsad approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@qwwdfsad qwwdfsad merged commit 4ef9e20 into dev Jul 17, 2020
@qwwdfsad qwwdfsad deleted the unify_dynamics branch September 19, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandwwraith @qwwdfsad