Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check shapes in arithmetic operations #59

Closed
devcrocod opened this issue Oct 12, 2021 · 2 comments · Fixed by #73
Closed

check shapes in arithmetic operations #59

devcrocod opened this issue Oct 12, 2021 · 2 comments · Fixed by #73
Labels
good first issue Good for newcomers

Comments

@devcrocod
Copy link
Collaborator

Add require of two shapes to each arithmetic operation between the two ndarrays.
Shapes must match exactly.
Now the check is only for the number of elements.
@devcrocod devcrocod added the good first issue Good for newcomers label Oct 12, 2021
@plastic-karma
Copy link
Contributor

Does this apply to and, or, max and min as well ?

plastic-karma added a commit to plastic-karma/multik that referenced this issue Nov 2, 2021
@plastic-karma
check shapes in arithmetic operations
d3e7fbc 
fixes Kotlin#59
@plastic-karma plastic-karma mentioned this issue Nov 2, 2021
Merged
@devcrocod
Copy link
Collaborator Author

devcrocod commented Nov 9, 2021 •
edited
Loading

Yes, it can be applied to these functions as well. I want to release version 0.1.1 with bug fixes as soon as possible, so I will add check in maximum myself.
thanks

devcrocod pushed a commit that referenced this issue Nov 9, 2021
@plastic-karma @devcrocod
check shapes in arithmetic operations
91b9aa3 
fixes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check shapes in arithmetic operations plastic-karma/multik
2 participants
@plastic-karma @devcrocod