unsafe variance: reword note and fix the notes code #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinIsland
force-pushed
the
fix/unsafe-variance
branch
from
314337a to
abeabaf
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
fix/unsafe-variance
branch
from
abeabaf to
96e7037
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
fix/unsafe-variance
branch
from
96e7037 to
8474ee7
Compare
This comment has been minimized.
This comment has been minimized.
DetachHead
reviewed
Apr 30, 2023
KotlinIsland
force-pushed
the
fix/unsafe-variance
branch
from
8474ee7 to
b636a8f
Compare
KotlinIsland
force-pushed
the
fix/unsafe-variance
branch
from
b636a8f to
43128e8
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: sympy (https://github.com/sympy/sympy) got 1.08x faster (3996.3s -> 3690.6s)
steam.py (https://github.com/Gobot1234/steam.py)
- steam/game_server.py:238:29: note: If this is intentional and you know what you are doing, you can ignore this line with 'unsafe-variance'
+ steam/game_server.py:238:29: note: If you are using the value in a 'variance safe' way (not storing or retrieving values), this error could be ignored
- steam/game_server.py:250: error: "type: ignore" comment without error code (consider "type: ignore[misc, unsafe-variance]" instead) [ignore-without-code]
+ steam/game_server.py:250: error: "type: ignore" comment without error code (consider "type: ignore[unsafe-variance]" instead) [ignore-without-code]
- steam/game_server.py:261: error: "type: ignore" comment without error code (consider "type: ignore[misc, unsafe-variance]" instead) [ignore-without-code]
+ steam/game_server.py:261: error: "type: ignore" comment without error code (consider "type: ignore[unsafe-variance]" instead) [ignore-without-code]
- steam/game_server.py:264: error: "type: ignore" comment without error code (consider "type: ignore[misc, unsafe-variance]" instead) [ignore-without-code]
+ steam/game_server.py:264: error: "type: ignore" comment without error code (consider "type: ignore[unsafe-variance]" instead) [ignore-without-code]
- steam/game_server.py:267: error: "type: ignore" comment without error code (consider "type: ignore[misc, unsafe-variance]" instead) [ignore-without-code]
+ steam/game_server.py:267: error: "type: ignore" comment without error code (consider "type: ignore[unsafe-variance]" instead) [ignore-without-code]
- steam/clan.py:163:15: note: If this is intentional and you know what you are doing, you can ignore this line with 'unsafe-variance'
+ steam/clan.py:163:15: note: If you are using the value in a 'variance safe' way (not storing or retrieving values), this error could be ignored
pytest (https://github.com/pytest-dev/pytest)
+ src/_pytest/_code/code.py:478: error: Unused "type: ignore" comment [unused-ignore]
+ src/_pytest/_code/code.py:478:20: note: If you are using the value in a 'variance safe' way (not storing or retrieving values), this error could be ignored
|
DetachHead
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
misc note was imposting as an attached note