Added settings for show_upcoming_events and show_past_events to control ... #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol whether or not lists for these show on the main page. Added a setting for calendar_position to control the position of the calendar relative to the lists, as above them, between them, or below them. These new settings are held in a calendar_settings object, as they pertain to the full page, and not to the upcoming_events_settings (renamed to be more explicit) used for the upcoming_events_widget.
…w finds events shown.
… site. Removed config params for Calendar, leaving config for the upcoming_events_widget, and adding functionality to the Calendar class, including a new scope property (calendar, recursive, or site wide search for events to be shown) and new select properties for controlling the appearance of an optional events list to accompany the calendar display. Moved the view code from the separate widgets.py into views.py, and updated views to use the decorator style. Improved code for recursive searching for events. Adjusted the readme and __init__.py for a more flexible way of configuring the upcoming_events_widget to any slot.
…ot widgets of some other add-ons -- looking for a consistent default style for such widgets.
…and past events are collected, with conditionals to avoid unneeded work. Also, in the related preparation for the return from calendar view code, dicts of upcoming and past events are put in a list and ordered according to properties. The template code simply iterates over the events_dicts provided, for either or both upcoming and past events lists. Fixed tests for new calendar properties and config settings.
…nd past events list, from h2/h3 to h3/h4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...whether or not lists for these show on the main page. Added a setting for calendar_position to control the position of the calendar relative to the lists, as above them, between them, or below them. These new settings are held in a calendar_settings object, as they pertain to the full page, and not to the upcoming_events_settings (renamed to be more explicit) used for the upcoming_events_widget.