Swap int to long for numeric values #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kount API supports passing up to 15 numeric characters for both TOTL and CASH https://kount.github.io/docs/ris-data-submission/ The API supports numbers up to 999999999999999, but `int` only supports numbers up to 2147483647. These fields should be represented as `long` rather than `int`.
gniofreitas
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kount API supports passing up to 15 numeric characters for both TOTL and CASH
https://kount.github.io/docs/ris-data-submission/
The API supports numbers up to 999999999999999, but
intonly supports numbers up to 2147483647.These fields should be represented as
longrather thanint.