Avoid endless loops when updating def attributes

Fix #413.
Kozea · Feb 13, 2024 · 051df1b · 051df1b
1 parent cf0c406
commit 051df1b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/cairosvg/defs.py b/cairosvg/defs.py
@@ -29,12 +29,15 @@
 }
 
 
-def update_def_href(surface, def_name, def_dict):
+def update_def_href(surface, def_name, def_dict, chain=None):
     """Update the attributes of the def according to its href attribute."""
     def_node = def_dict[def_name]
     href = parse_url(def_node.get_href()).fragment
-    if href in def_dict:
-        update_def_href(surface, href, def_dict)
+    if chain is None:
+        chain = set()
+    if href in def_dict and href not in chain:
+        chain.add(href)
+        update_def_href(surface, href, def_dict, chain)
         href_node = def_dict[href]
         def_dict[def_name] = Tree(
             url=f'#{def_name}', url_fetcher=def_node.url_fetcher,