Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math optimizations #397

Merged
merged 3 commits into from
Aug 19, 2023
Merged

Math optimizations #397

merged 3 commits into from
Aug 19, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Aug 5, 2023

A few math optimizations:

  1. Use integers where appropriate (floats were needed in Python2)
  2. Introduce math.* methods where useful
  3. Simplify a few conditions

@eumiro eumiro force-pushed the math branch 3 times, most recently from 13b6dcb to 58f75c3 Compare August 5, 2023 18:24
@eumiro eumiro marked this pull request as ready for review August 5, 2023 18:40
@liZe
Copy link
Member

liZe commented Aug 19, 2023

Thank you!

@liZe liZe merged commit 7468122 into Kozea:master Aug 19, 2023
2 checks passed
@eumiro eumiro deleted the math branch August 19, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liZe liZe liZe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eumiro @liZe