Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathlib #398

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Use pathlib #398

merged 1 commit into from
Aug 20, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Aug 19, 2023

Use pathlib.Path for path operations where possible. The test methods are then calling the code with strings, so it would be nice to make the code working for os.PathLike in general.

@eumiro eumiro marked this pull request as ready for review August 19, 2023 17:07
@liZe
Copy link
Member

liZe commented Aug 20, 2023

Thanks a lot!

The test methods are then calling the code with strings, so it would be nice to make the code working for os.PathLike in general.

Yes, that would be useful!

@liZe liZe merged commit d9ce00a into Kozea:master Aug 20, 2023
2 checks passed
@eumiro eumiro deleted the pathib branch August 20, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eumiro @liZe