Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues #74 and #100 : trailing space crash #102

Closed
wants to merge 3 commits into from

Conversation

jamma313
Copy link
Contributor

If available width is known and equals to 0, we don't have space to write to, so return.

@SimonSapin
Copy link
Member

I’m not confident with this part of the code. @liZe , could you review?

@liZe
Copy link
Member

liZe commented Oct 17, 2013

The second commit is OK (yes, that's a 'bad' cutting value from pango, and your solution is a not-so-bad workaround). But the first commit is false and should not be merged. Having no available space is not a sufficient reason to skip text, we must draw it even if it goes outside the box, it will be clipped if overflow is set to hidden. You can try with the example given in #74, the text must be visible.

By the way, this commit fixes #74 but not #100 for me. Did I miss something?

@jamma313
Copy link
Contributor Author

Yes you're right.
First commit was wrong, and sometimes truncated text.
I saw this a little bit after doing the pull request, but still was testing it.

#100 was fixed by first commit, so it is still bugged.

@liZe
Copy link
Member

liZe commented Dec 14, 2013

I've merged your second commit, thanks!

@liZe liZe closed this Dec 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants