Try fixing a bug encountered when using weasyprint in Pyinstaller context #1089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging
weasyprint
as a dependency in a Pyinstaller project, it looks for theVERSION
file in the rootsys._MEIPASS
when the actual file ends up insys._MEIPASS
's subdirectoryweasyprint
. This pull request fixes that.Maybe there's a reason the code is currently implemented this way. In that case I wouldn't mind to look for a solution to support all use cases.
Sample stack trace of the problem on runtime of an executable created with PyInstaller: