Dont clip page margins on account of body overflow #1141
Conversation
Though the `overflow` on the root element must be propagated to the viewport we mustn't cut off the page margins in `draw_stacking_context()` 1. never clip when a PageBox is rendered 2. do the proposed clip when drawing the <BlockBox html> fixes Kozea#35
|
Any idea how a unit-test would look like? Checking pixels of a |
| if box.style['overflow'] != 'visible': | ||
| # dont clip the PageBox, see #35 | ||
| if box.style['overflow'] != 'visible' and not isinstance( | ||
| box, boxes.PageBox): |
weasyprint/draw.py
Outdated
| @@ -184,6 +184,15 @@ def draw_stacking_context(context, stacking_context, enable_hinting): | |||
| # See http://www.w3.org/TR/CSS2/zindex.html | |||
| with stacked(context): | |||
| box = stacking_context.box | |||
|
|
|||
| # apply the viewport_overflow to the html box, see #35 | |||
| if box.element_tag == 'html' and ( | |||
There was a problem hiding this comment.
Shouldn’t we use box.is_for_root_element instead?
There was a problem hiding this comment.
Wasn't aware that there is a box.is_for_root_element.
Though, I always wondered about the # No root element fallback in build_formatting_structure(). Never ever managed to construct an HTML/element_tree without a 'html' root node.
There was a problem hiding this comment.
Though, I always wondered about the
# No root elementfallback inbuild_formatting_structure(). Never ever managed to construct an HTML/element_tree without a 'html' root node.
Good question, I don’t know if html5lib can give a document with no root html tag. Coverage says that this code is tested, so I suppose that it’s useful 😄.
By the way, it’s easier to have an html tag nested in another html tag, that’s another good reason to use is_for_root_element.
There was a problem hiding this comment.
have an html tag nested in another html tag
I tried that, too. Various scaring nestings of html and body. Creating multiple and/or nested BlockBox body is possible.
But always ended up with one single BlockBox html root element.
There was a problem hiding this comment.
😱
WeasyPrint/weasyprint/tests/test_boxes.py
Lines 1324 to 1334 in f333cef
That’s good news.
👍 |
|
Thank you, thank you, thank you… |
If we want the
viewport_overflowrestriction being applied to the<BlockBox html>only, the instructions fordraw_stacking_context()are:<BlockBox html>whose page's overflow isn'tvisibleGood thing is:
We can rely upon the
with stacked(context)statement to save and restore the context state automagically.fixes #35