Sort anchors across pages #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had sorted anchors within one page, but if anchors happened to be out of order *across* pages, they wouldn't be written in order, which caused lingering issues in some viewers. Related to Kozea#1352 and the change in d4561b1.
|
Apologies, I thought I had removed all of my debugging before committing. This should work better. (Feel free to squash / commit separately - I didn't want to amend the last commit in case you had pulled it.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had sorted anchors within one page, but if anchors happened to be out of order in subsequent pages, they wouldn't be written in order, which caused lingering issues in some PDF viewers.
Related to #1352 and the change in d4561b1.
I'm not a huge fan of using lists to store different types of data indexed by position, but this was a quick way to do it that gets handled well by
sorted. I won't be offended if you want to rewrite it using dicts or something else that might be more Pythonic. 🙂