Fixing usage across libraries / translation units #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few tests that cover different scenarios
The solution I propose seems to work for all of them :)
Now I think we could leave it as header only and still have it working properly!
EDIT: Note that this solution also works without any
extern
!closes #184
for reference: https://stackoverflow.com/questions/23690416/c-template-singleton-static-pointer-initialization-in-header-file