-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ModelPart] improving speed of creating entities #314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooyan-dadvand
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR improves the speed of creating entities tremendously
on my machine creating 10 million nodes now takes ~10s
previously creating 64.000 nodes took ~20s 😅
This improvement is achieved by using a custom container for the entities instead of
std::vector
The key difference is that (as discussed) I created a new container that stores an . This way any
find
operation is much much faster. (the entities are still stored in a vector as before, but I can now access them by Id much faster which is used extensively in the creation of entities)Additionally an interface for creating many entities at once is proposed. This one is TBD. For now the only improvement over the individual creation is the upfront reservation of memory, which makes it ~10-15% faster. This is less than I was hoping for/expected. I played around with creating entities in parallel, but then the Id-checks are more expensive which in turn pretty much nullifies the advantages of the parallelism