Optapp/ Adding QNBB line search technique #11431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunethwarna I am not sure if it is a good solution to convert all line searches to compute vector of constant step values. The reason is that typically, line search returns single value. QNBB is not a typical case and may be it is better to keep it as a unique case and do not convert other line search techniques in the same manner. What do you think? I am open for any suggestions. |
Igarizza
changed the title
matekelemen
reviewed
Jul 26, 2023
applications/OptimizationApplication/python_scripts/algorithms/algorithm_steepest_descent.py
Outdated
Show resolved
Hide resolved
applications/OptimizationApplication/python_scripts/algorithms/algorithm_steepest_descent.py
Show resolved
Hide resolved
Igarizza
force-pushed
the
optapp/qnbb_method
branch
from
361acf3
to
058f150
Compare
sunethwarna
previously approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Thanks @Igarizza :)
Could you fix the codacy suggestions? They are valid for this PR.
sunethwarna
reviewed
Aug 23, 2023
applications/OptimizationApplication/python_scripts/utilities/opt_line_search.py
Show resolved
Hide resolved
applications/OptimizationApplication/python_scripts/utilities/opt_line_search.py
Outdated
Show resolved
Hide resolved
sunethwarna
previously approved these changes
Aug 24, 2023
sunethwarna
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
PR implements the possibility to combine SD with QN-BB method, where the step size is computed for each design variable. New function Compute Step Size is returning collective expression with different step sizes.
🆕 Changelog
Please summarize the changes in one list to generate the changelog:
The PR is based on the PR #11421
E.g.