[CLApp] Implementing fatigue data container #11494

atfard · 2023-08-21T11:15:34Z

📝 Description
In this PR, a fatigue data container has been added. Using this class, it would be much easier to incorporate fatigue calculations in other constitutive laws.
@SergioJimenezReyes @lagoncalvesjr @balcayde @lgratiela

loumalouomega · 2023-08-21T11:19:57Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+        const Vector& r_aux_stresses = mPreviousStresses;
+        rFatigueVariables.PreviousStresses[1] = CurrentStress;
+        rFatigueVariables.PreviousStresses[0] = r_aux_stresses[1];
+        // mPreviousStresses = rFatigueVariables.PreviousStresses;


loumalouomega · 2023-08-21T11:20:49Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+        bool DamageActivation;
+    };
+
+	HCFDataContainer()


Remove the tabulation

loumalouomega · 2023-08-21T11:21:28Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+ConstitutiveLaw::Parameters rValues = ConstitutiveLaw::Parameters();
+public:
+
+    struct FatigueVariables {


Every variable must be saved in every GP, there are not common values that can be stored in properties?

I agree, some double values can be recomuted, not being necessary to be stored

these are all fatigue variables which have been gathered in one place. Not all of them are stored but the remaining ones are necessary for calculations.

loumalouomega · 2023-08-21T11:22:30Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+
+    ///@name Member Variables
+    ///@{
+    double mMaxStress = 0.0;


Idem, a lot of variables, it is required for every GP?

After checking the HCF CL, yes, it needs tracking of many things...

BTW, the member variables should be in the private section of the class

AlejandroCornejo · 2023-08-21T11:17:32Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+        double Alphat = 0.0;
+        double PreviousReversionFactor = 0.0;
+        double ReversionFactor = 0.0;
+        bool AdnvanceStrategyApplied;


there is a typo here

AlejandroCornejo · 2023-08-21T11:18:41Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+                                                                            rFatigueVariables.MinIndicator);
+        const Vector& r_aux_stresses = mPreviousStresses;
+        rFatigueVariables.PreviousStresses[1] = CurrentStress;
+        rFatigueVariables.PreviousStresses[0] = r_aux_stresses[1];


Where is the r_aux_stresses ? This cannot compile

sorry I did not read it right, it is okkey

AlejandroCornejo · 2023-08-21T11:20:09Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+
+    void CalculateFatigueReductionFactorAndWohlerStress(const Properties& rMaterialParameters, HCFDataContainer::FatigueVariables &rFatigueVariables)
+    {
+        HighCycleFatigueLawIntegrator<6>::CalculateFatigueReductionFactorAndWohlerStress(rMaterialParameters,


We should separate this file into .cpp and .h

AlejandroCornejo · 2023-08-21T11:20:47Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+
+            CalculateFatigueParameters(rMaterialProperties, rFatigueVariables);
+
+            double betaf = rMaterialProperties[HIGH_CYCLE_FATIGUE_COEFFICIENTS][4];


AlejandroCornejo · 2023-08-21T11:22:12Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+
+            double betaf = rMaterialProperties[HIGH_CYCLE_FATIGUE_COEFFICIENTS][4];
+
+            if (std::abs(rFatigueVariables.MinStress) < 0.001) {


we should set this tolerance as a static constexpr double tolerance = 1.0e-3; like we do in the plasticity integrator

AlejandroCornejo · 2023-08-21T11:22:33Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+
+            CalculateFatigueReductionFactorAndWohlerStress(rMaterialProperties, rFatigueVariables);
+        }
+        if (rFatigueVariables.AdnvanceStrategyApplied) {


loumalouomega

Some comments

AlejandroCornejo · 2023-08-21T12:56:45Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+                                                                            rFatigueVariables.MinIndicator);
+        const Vector& r_aux_stresses = mPreviousStresses;
+        rFatigueVariables.PreviousStresses[1] = CurrentStress;
+        rFatigueVariables.PreviousStresses[0] = r_aux_stresses[1];


sorry I did not read it right, it is okkey

AlejandroCornejo · 2023-08-22T05:08:04Z

...tions/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.cpp

+        CalculateFatigueParameters(rMaterialProperties, rFatigueVariables);
+
+        const double betaf = rMaterialProperties[HIGH_CYCLE_FATIGUE_COEFFICIENTS][4];
+        static constexpr double tolerance = 1.0e-3;


This declaration you should do it in the .h file, see plasticity integrator

AlejandroCornejo · 2023-08-22T05:08:47Z

...tions/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.cpp

+        }
+        rFatigueVariables.MaxStressRelativeError = std::abs((rFatigueVariables.MaxStress - rFatigueVariables.PreviousMaxStress) / rFatigueVariables.MaxStress);
+
+        if (!rFatigueVariables.DamageActivation && rFatigueVariables.GlobalNumberOfCycles > 2 && !rFatigueVariables.AdvanceStrategyApplied && (rFatigueVariables.ReversionFactorRelativeError > 0.001 || rFatigueVariables.MaxStressRelativeError > 0.001)) {


What tolerance we use here instead of hardcoding 0.001?

AlejandroCornejo · 2023-08-22T05:10:05Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+
+    ///@name Member Variables
+    ///@{
+    double mMaxStress = 0.0;


After checking the HCF CL, yes, it needs tracking of many things...

AlejandroCornejo · 2023-08-22T05:10:39Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+
+    ///@name Member Variables
+    ///@{
+    double mMaxStress = 0.0;


BTW, the member variables should be in the private section of the class

AlejandroCornejo · 2023-08-22T09:57:53Z

seems good now @SergioJimenezReyes

AlejandroCornejo

my last comments

AlejandroCornejo · 2023-08-23T04:36:11Z

...tions/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.cpp

+                        ConstitutiveLaw::StressVectorType stress_vector,
+                        double uniaxial_stress)
+{
+    double sign_factor = CalculateTensionOrCompressionIdentifier(stress_vector);


AlejandroCornejo · 2023-08-23T04:40:48Z

...tions/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.cpp

+
+    CalculateSminAndSmax(uniaxial_stress, rFatigueVariables);
+
+    rFatigueVariables.AdvanceStrategyApplied = rCurrentProcessInfo[ADVANCE_STRATEGY_APPLIED];


retrieving something without checking if has been set is dangerous... Think that somebody could use this class without the AITS. I'd use:

``

Suggested change

rFatigueVariables.AdvanceStrategyApplied = rCurrentProcessInfo[ADVANCE_STRATEGY_APPLIED];

rFatigueVariables.AdvanceStrategyApplied = rCurrentProcessInfo.Has(ADVANCE_STRATEGY_APPLIED) ? rCurrentProcessInfo[ADVANCE_STRATEGY_APPLIED : false;

AlejandroCornejo · 2023-08-23T04:42:48Z

...cations/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.h

+    {};
+
+    // Defining fatigue methods
+


BTW I think that we need a new method called Check which ensures that the material properties have the required Fatigue parameters in them.

to be called in the Check from the CL

atfard · 2023-08-23T10:00:57Z

A check method has been added.

AlejandroCornejo · 2023-08-23T10:02:59Z

...tions/ConstitutiveLawsApplication/custom_constitutive/auxiliary_files/hcf_data_container.cpp

    uniaxial_stress *= sign_factor;

    CalculateSminAndSmax(uniaxial_stress, rFatigueVariables);

-    rFatigueVariables.AdvanceStrategyApplied = rCurrentProcessInfo[ADVANCE_STRATEGY_APPLIED];
+    rFatigueVariables.AdvanceStrategyApplied = rCurrentProcessInfo.Has(ADVANCE_STRATEGY_APPLIED) ? rCurrentProcessInfo[ADVANCE_STRATEGY_APPLIED] : false;
    rFatigueVariables.DamageActivation = rCurrentProcessInfo[DAMAGE_ACTIVATION];


you should do the same with this one, use Has()

all those variables set by the AITS, we should check because we may not use AITS

AlejandroCornejo

nice!

HCF data container and its test added

90916d6

atfard added the Enhancement label Aug 21, 2023

atfard assigned loumalouomega Aug 21, 2023

atfard requested a review from a team as a code owner August 21, 2023 11:15

atfard assigned AlejandroCornejo and SergioJimenezReyes Aug 21, 2023

loumalouomega reviewed Aug 21, 2023

View reviewed changes

AlejandroCornejo reviewed Aug 21, 2023

View reviewed changes

loumalouomega reviewed Aug 21, 2023

View reviewed changes

atfard added 2 commits August 21, 2023 14:51

First-stage modifications

caaaedd

.cpp and .h files modified

3f90616

AlejandroCornejo reviewed Aug 22, 2023

View reviewed changes

atfard added 3 commits August 22, 2023 09:00

Minor changes

ca7f405

Modifying tolerance

a4f602e

Modifying CalculateFatigueParameters and adding if condition for WohlerS

4b5f599

AlejandroCornejo reviewed Aug 23, 2023

View reviewed changes

atfard added 2 commits August 23, 2023 07:59

Some modifications on variables

e3c299a

Check method added

009293b

AlejandroCornejo reviewed Aug 23, 2023

View reviewed changes

modify AIT entries

dc04f6c

AlejandroCornejo self-requested a review August 23, 2023 10:31

AlejandroCornejo approved these changes Aug 23, 2023

View reviewed changes

atfard merged commit 99e9d01 into master Aug 23, 2023
11 checks passed

atfard deleted the HCFDataContainer branch August 23, 2023 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CLApp] Implementing fatigue data container #11494

[CLApp] Implementing fatigue data container #11494

atfard commented Aug 21, 2023

loumalouomega Aug 21, 2023

loumalouomega Aug 21, 2023

loumalouomega Aug 21, 2023

AlejandroCornejo Aug 21, 2023

atfard Aug 21, 2023

loumalouomega Aug 21, 2023

AlejandroCornejo Aug 22, 2023

AlejandroCornejo Aug 22, 2023

atfard Aug 22, 2023

AlejandroCornejo Aug 21, 2023

AlejandroCornejo Aug 21, 2023

AlejandroCornejo Aug 21, 2023

AlejandroCornejo Aug 21, 2023

atfard Aug 21, 2023

AlejandroCornejo Aug 21, 2023

AlejandroCornejo Aug 21, 2023

AlejandroCornejo Aug 21, 2023

loumalouomega left a comment

AlejandroCornejo Aug 21, 2023

AlejandroCornejo Aug 22, 2023

atfard Aug 22, 2023

AlejandroCornejo Aug 22, 2023

AlejandroCornejo Aug 22, 2023

AlejandroCornejo Aug 22, 2023

AlejandroCornejo commented Aug 22, 2023

AlejandroCornejo left a comment

AlejandroCornejo Aug 23, 2023

AlejandroCornejo Aug 23, 2023

AlejandroCornejo Aug 23, 2023

AlejandroCornejo Aug 23, 2023

atfard commented Aug 23, 2023

AlejandroCornejo Aug 23, 2023

AlejandroCornejo Aug 23, 2023

AlejandroCornejo left a comment


		CalculateFatigueParameters(rMaterialProperties, rFatigueVariables);

		double betaf = rMaterialProperties[HIGH_CYCLE_FATIGUE_COEFFICIENTS][4];


		double betaf = rMaterialProperties[HIGH_CYCLE_FATIGUE_COEFFICIENTS][4];

		if (std::abs(rFatigueVariables.MinStress) < 0.001) {


		CalculateSminAndSmax(uniaxial_stress, rFatigueVariables);

		rFatigueVariables.AdvanceStrategyApplied = rCurrentProcessInfo[ADVANCE_STRATEGY_APPLIED];

[CLApp] Implementing fatigue data container #11494

[CLApp] Implementing fatigue data container #11494

Conversation

atfard commented Aug 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loumalouomega left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlejandroCornejo commented Aug 22, 2023

AlejandroCornejo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atfard commented Aug 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlejandroCornejo left a comment

Choose a reason for hiding this comment