Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Split Checks #11526

Merged
merged 8 commits into from
Aug 30, 2023
Merged

[Testing] Split Checks #11526

merged 8 commits into from
Aug 30, 2023

Conversation

roigcarlo
Copy link
Member

@roigcarlo roigcarlo commented Aug 30, 2023 •
edited
Loading

📝 Description
This splits the check.h file into two. Expect and Check. Incode checks reamin the same, and tests assertions will use the expect interface. This change does nothing by its own and its needed for #11506 as requested by @loumalouomega.

String checks may require further changes in the GTest PR.

🆕 Changelog

  • Split check.h in check.h and expect.h

@roigcarlo roigcarlo requested review from a team as code owners August 30, 2023 10:05
@roigcarlo roigcarlo temporarily deployed to github-pages August 30, 2023 10:07 — with GitHub Actions Inactive
loumalouomega
loumalouomega previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only these changes then Okay. But maybe should a warning be added in Cmake, otherwise many branches of developers may not compile or change behaviour

@roigcarlo
Copy link
Member Author

roigcarlo commented Aug 30, 2023 •
edited
Loading

I would add the warning in the other PR, this at most will cause a couple of tests from branches to fail, but if they keep using checks it will break nothing

Added the warning

@roigcarlo roigcarlo temporarily deployed to github-pages August 30, 2023 10:18 — with GitHub Actions Inactive
@roigcarlo roigcarlo temporarily deployed to github-pages August 30, 2023 12:05 — with GitHub Actions Inactive
loumalouomega
loumalouomega previously approved these changes Aug 30, 2023
View reviewed changes
@loumalouomega
Copy link
Member

Some CI still failing

@roigcarlo roigcarlo temporarily deployed to github-pages August 30, 2023 13:31 — with GitHub Actions Inactive
loumalouomega
loumalouomega previously approved these changes Aug 30, 2023
View reviewed changes
@loumalouomega
Copy link
Member

Some Ci are failing due segmentation fault

@roigcarlo
Copy link
Member Author

@loumalouomega I am aware. I get mails from the CI

loumalouomega
loumalouomega previously approved these changes Aug 30, 2023
View reviewed changes
@loumalouomega
Copy link
Member

@loumalouomega I am aware. I get mails from the CI

I was trying to help :`(

@roigcarlo roigcarlo temporarily deployed to github-pages August 30, 2023 15:08 — with GitHub Actions Inactive
@roigcarlo roigcarlo temporarily deployed to github-pages August 30, 2023 15:54 — with GitHub Actions Inactive
@roigcarlo roigcarlo merged commit 366949e into master Aug 30, 2023
18 checks passed
@roigcarlo roigcarlo deleted the core/split-checl-expect branch August 30, 2023 18:01
@roigcarlo roigcarlo mentioned this pull request Aug 31, 2023
Open
@loumalouomega loumalouomega mentioned this pull request Aug 31, 2023
Merged
@roigcarlo roigcarlo mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loumalouomega loumalouomega loumalouomega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roigcarlo @loumalouomega