Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix python name exposure #11538

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[Core] Fix python name exposure #11538

merged 1 commit into from
Sep 5, 2023

Conversation

sunethwarna
Copy link
Member

@sunethwarna sunethwarna commented Sep 5, 2023 •
edited
Loading

📝 Description
The stub generation and mypy static type checking fail for the core since the name used for the GetComponentIndex when exposing is wrong. This PR fixes it.

🆕 Changelog

  • Fix python exposure name.

@sunethwarna sunethwarna added Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast Bugfix labels Sep 5, 2023
@sunethwarna sunethwarna requested a review from a team as a code owner September 5, 2023 10:14
@sunethwarna sunethwarna self-assigned this Sep 5, 2023
@sunethwarna sunethwarna merged commit 0dbae6c into master Sep 5, 2023
11 checks passed
@sunethwarna sunethwarna deleted the core/fix_method_name branch September 5, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loumalouomega loumalouomega loumalouomega approved these changes

Assignees

@sunethwarna sunethwarna

Labels
Bugfix FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunethwarna @loumalouomega