Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Addressed a number of code smells #11544

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

mnabideltares
Copy link
Contributor

📝 Description
CoSim branch encountered more than 100 code smells. They are mainly related to redundant comments in the code.
As CoSim branch is not independent (it is branch of a branch), we decided to fix these issues in the master and then merge them back to that branch

🆕 Changelog

  • Addressed code smells, mainly removing the redundant comments

@mnabideltares mnabideltares linked an issue Sep 7, 2023 that may be closed by this pull request
3 tasks
@mnabideltares mnabideltares self-assigned this Sep 7, 2023
@mnabideltares mnabideltares added GeoMechanics Issues related to the GeoMechanicsApplication Cleanup labels Sep 7, 2023
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. Thanks for the hard work Mohamed!

@avdg81 avdg81 merged commit dd4bb40 into master Sep 8, 2023
11 checks passed
@avdg81 avdg81 deleted the geo/11542-codesmells-cosim branch September 8, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup GeoMechanics Issues related to the GeoMechanicsApplication
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Fix the code smells for CoSim branch
2 participants