[Fluid] Weakly-compressible automatic differentiation enhancements #11646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR upgrades the current weakly-compressible AD scripts to include a Darcy term contribution. Besides, I took the chance to add a test, upgrade the Jupyter file with the formulation derivation and to properly name and move the files.
Note: while doing so I found a small error in the stabilization constants of the Stokes element which are now correct (the same script is used). However I didn't generate the element again to avoid polluting this PR. I'll do so in a follow up PR. My idea is to separate the Stokes in a different generation folder but calling this script from an auxiliary one.