Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Document pointer_vector_set.h #11655

Merged
merged 3 commits into from
Oct 4, 2023
Merged

[Core] Document pointer_vector_set.h #11655

merged 3 commits into from
Oct 4, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

This PR refactors the PointerVectorSet class in the containers/pointer_vector_set.h file. The changes made in this commit include:

  • Updating the license information.
  • Replacing some typedefs with the 'using' keyword for improved code readability.
  • Adding comments and documentation for the class and its functions.

🆕 Changelog

@loumalouomega loumalouomega added Cleanup Kratos Core Documentation FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Oct 4, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner October 4, 2023 08:57
rubenzorrilla
rubenzorrilla approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly documentation with some aesthetics and whitespaces. Thanks for the effort.

@loumalouomega loumalouomega merged commit d388b88 into master Oct 4, 2023
11 checks passed
@loumalouomega loumalouomega deleted the core/document-pointer-vector-set branch October 4, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenzorrilla rubenzorrilla rubenzorrilla approved these changes

@roigcarlo roigcarlo Awaiting requested review from roigcarlo

Assignees
No one assigned
Labels
Cleanup Documentation FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loumalouomega @rubenzorrilla