Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Isolated Hencky strain computation, such that it appears once. #11667

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

WPK4FEM
Copy link
Contributor

@WPK4FEM WPK4FEM commented Oct 6, 2023

The computation of Hencky strain ( logarithmic strain or natural strain ) has been moved from the element implementations to stress_strain_utilities, such that code duplication is avoided.
Added stretch, rigid rotation and pure shear unit tests.

@WPK4FEM WPK4FEM added the GeoMechanics Issues related to the GeoMechanicsApplication label Oct 6, 2023
@WPK4FEM WPK4FEM self-assigned this Oct 6, 2023
rfaasse
rfaasse previously approved these changes Oct 6, 2023
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that we got rid of another duplicate function and added a unit test! I have some suggestions and questions, but none of them are really blocking.

avdg81
avdg81 previously approved these changes Oct 6, 2023
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, nice cleanup!

Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@avdg81 avdg81 merged commit 3571f86 into master Oct 6, 2023
11 checks passed
@avdg81 avdg81 deleted the geo/test-hencky-strain branch October 6, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Investigate and test Hencky ( = natural = logarithmic ) strains
3 participants