Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MedApp] more geom types and other minor improvements #11684

Merged
merged 13 commits into from
Oct 17, 2023

Conversation

philbucher
Copy link
Member

basically support for more geometry types including lots of testing

Hexa20 & Hexa27 are still missing

@matekelemen
Copy link
Contributor

how about tracking the mesh files with git lfs instead of git directly?
@roigcarlo ?

"""{
"elements_list" : [{
"model_part_name" : "read_1",
"element_name" : "Element2D3N;Element2D4N;Element3D4N;Element3D8N;Element3D10N;Element3D20N;Element3D27N"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's is unrelated to this PR, but why isn't this a list of strings instead of a ; delimited one??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@philbucher
Copy link
Member Author

how about tracking the mesh files with git lfs instead of git directly? @roigcarlo ?

oh boy, I think the size-of-repo battle is lost for Kratos 🙈
I keep the meshes very small, and will not add many more, thus I think it is not worth the additional struggle

@roigcarlo
Copy link
Member

how about tracking the mesh files with git lfs instead of git directly? @roigcarlo ?

oh boy, I think the size-of-repo battle is lost for Kratos 🙈 I keep the meshes very small, and will not add many more, thus I think it is not worth the additional struggle

Not against using lfs, but for the existing repo that would require a history rewrite. I've been simulating the process in my private copy, but it still gives problems. I promise one day we will do it.

Also lfs is only 5GB of sotrage so we cannot go wild.

@loumalouomega
Copy link
Member

Also lfs is only 5GB of sotrage so we cannot go wild.

shrek_movie.mdpa

@philbucher philbucher merged commit a59295d into master Oct 17, 2023
10 of 11 checks passed
@philbucher philbucher deleted the med/more-geom-types branch October 17, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants