Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Fixed the model part used by the process creators for settlement #11692

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

avdg81
Copy link
Contributor

@avdg81 avdg81 commented Oct 17, 2023

📝 Description
The name of the model part that is associated with a process, is kept by the process parameters. Look up the model part by name and pass that to the constructor of a process rather than the complete model part that is created by the settlement workflow.

The name of the model part that is associated with a process, is kept by
the process parameters. Look up the model part by name and pass that to
the constructor of a process rather than the complete model part that is
created by the settlement workflow.
@avdg81 avdg81 added Bugfix GeoMechanics Issues related to the GeoMechanicsApplication labels Oct 17, 2023
@avdg81 avdg81 self-assigned this Oct 17, 2023
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, no comments!

@avdg81 avdg81 merged commit ad067ba into master Oct 18, 2023
9 of 11 checks passed
@avdg81 avdg81 deleted the geo/fixed-process-creators-for-settlement branch October 18, 2023 07:58
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants