Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Updated multiple moving load tests to work and to run #11722

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

mcgicjn2
Copy link
Contributor

📝 Description
Updated geomechanics testing to include the running of test set multiple moving loads automatically.
Updated the logic to include changes made to moving loads (structural mechanics)
Reduced duplication and code smells

@mcgicjn2 mcgicjn2 marked this pull request as ready for review October 27, 2023 05:51
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactoring and code duplication reduction, looks a lot cleaner than before! I have a few minor comments/suggestions and one question about the newly added solving strategy.

Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes and improving (and running) this test case!

@rfaasse rfaasse changed the title Updated multiple moving load tests to work and to run [GeoMechanicsApplication] Updated multiple moving load tests to work and to run Nov 9, 2023
@rfaasse rfaasse merged commit bba0361 into master Nov 9, 2023
10 of 11 checks passed
@rfaasse rfaasse deleted the geo/add_set_multi_load_tests branch November 9, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants