[OptApp] Fixing tolerance issue in the test #11760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunethwarna
added
Applications
Python
Hotfix
FastPR
sunethwarna
requested review from
roigcarlo,
Igarizza,
loumalouomega and
RezaNajian
Igarizza
previously approved these changes
Nov 3, 2023
| @@ -277,7 +292,7 @@ def test_vector_shell_filter(self): | |||
|
|
|||
| filtered_field = self.shell_vector_filter.UnFilterField(unfiltered_uniform_field_nodal) | |||
| filtered_field = self.shell_vector_filter.FilterField(filtered_field) | |||
| self.assertAlmostEqual(KOA.ExpressionUtils.NormL2(filtered_field), 5.196058, 4) | |||
| self.assertAlmostEqual(KOA.ExpressionUtils.NormL2(filtered_field), 5.196153341144455, 4) | |||
There was a problem hiding this comment.
The number is close, what I get on Mac Os with amgcl.
|
Hmm... now its failing in |
|
Can someone pre-approve... @rubenzorrilla @roigcarlo @Igarizza @matekelemen ? |
roigcarlo
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
As you have noticed, OptApp started having a test failure in CI. It was due to tolerance of the
AMGCLsolver used in solving the PDE. Now I changed everything to useIntel-Pardisodirect solver so not to have tolerance issues.Sorry for the inconvinience.
🆕 Changelog