[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12997

mnabideltares · 2025-01-10T09:43:08Z

Description:

To enhance our computational model for simulating high capacity heat storage systems, we need to implement a pressure "wel/filter" element on top of the existing pressure line element. The pressure filter element will enable us to model the behavior of heat storage under the ground, accounting for their heat exchange processes. This addition is crucial for achieving realistic simulations of heat storage systems and optimizing their performance.

🆕 Changelog

Added the contribution to bodyflow, compressibility matrix (by means of Biot), and constutative law
Added test cases
Documentation

… takes into account the projected gravity.

rfaasse

Thanks for implementing this functionality! I have a few suggestions for clean-up but all in all it's clear (of course I may be a bit biased here 😄 )!

applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.h

applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.cpp

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

applications/GeoMechanicsApplication/custom_retention/retention_law_factory.h

rfaasse · 2025-01-10T13:38:30Z

applications/GeoMechanicsApplication/custom_utilities/element_utilities.cpp

+        const double equivalent_radius_square = Prop[CROSS_AREA] / Globals::Pi;
+        rPermeabilityMatrix(0, 0)             = equivalent_radius_square * 0.125;


I would not expect the 'FillPermeabilityMatrix' function to perform a calculation here ($H(0,0) = 0.125 A/\pi$). I'm not too sure if there is a better place for it though, do you have any ideas?

applications/GeoMechanicsApplication/tests/test_pressure_line_element/README.md

WPK4FEM

Hi Mohammed,
Thank you for the work done. I'm not understanding an important point, the nature of the law itself. Please teach me.
Wijtze Pieter

applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.cpp

applications/GeoMechanicsApplication/custom_retention/retention_law_factory.h

applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.h

...tion/tests/test_pressure_line_element/test_oblique_filter_element2D3N/ProjectParameters.json

avdg81

This seems a nice extension to me, with documentation and tests. Well done! I have several minor suggestions and a few questions, but nothing major.

applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.cpp

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

applications/GeoMechanicsApplication/tests/test_pressure_line_element/README.md

...ion/tests/test_pressure_line_element/test_oblique_filter_element2D3N/MaterialParameters.json

...tion/tests/test_pressure_line_element/test_oblique_filter_element2D3N/ProjectParameters.json

...ion/tests/test_pressure_line_element/test_oblique_filter_element3D3N/MaterialParameters.json

...tion/tests/test_pressure_line_element/test_oblique_filter_element3D3N/ProjectParameters.json

WPK4FEM

Dear Mohamed,
Thank you for all the work.
I have still some remarks of which some may even be done at an other time.
I would appreciate if the specific resulting formulas from you PDF document could be includes in GeoMechanicsApplication/custom_constitutive/README.md
Regards, Wijtze Pieter

WPK4FEM · 2025-01-14T12:20:59Z

applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.cpp

+    const double result =
+        1.0 / (r_properties[DENSITY_WATER] * ProjectedGravity * r_properties[FILTER_LENGTH]) +
+        1.0 / r_properties[BULK_MODULUS_FLUID];
+    return result;


Why not:
return 1.0 / (r_properties[DENSITY_WATER] * ProjectedGravity * r_properties[FILTER_LENGTH]) +
1.0 / r_properties[BULK_MODULUS_FLUID];
There is no need for the intermediate variable result.

WPK4FEM · 2025-01-14T12:28:24Z

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

+        for (std::size_t i = 0; i < number_integration_points; ++i) {
+            J_container[i].resize(GetGeometry().WorkingSpaceDimension(),
+                                  GetGeometry().LocalSpaceDimension(), false);
+        }


Probably Sonar Cloud will give a remark about this that can be avoided as follows:
for ( auto& j: J_container ) {
j.resize(GetGeometry().WorkingSpaceDimension(), GetGeometry().LocalSpaceDimension(), false);
}

WPK4FEM · 2025-01-14T12:56:41Z

...ion/tests/test_pressure_line_element/test_oblique_filter_element2D3N/MaterialParameters.json

+        "IGNORE_UNDRAINED"                 : false,
+        "DENSITY_SOLID"                    : 2.650000e+03,
+        "DENSITY_WATER"                    : 1.000000e+03,
+        "POROSITY"                         : 1.000000e-01,
+        "BULK_MODULUS_SOLID"               : 9.000000e+19,
+        "BULK_MODULUS_FLUID"               : 1.000000e+20,
+        "PERMEABILITY_XX"                  : 9.084000e-06,
+        "DYNAMIC_VISCOSITY"                : 1.000000e-03,
+        "RETENTION_LAW"                    : "PressureFilterLaw",
+        "CROSS_AREA"                       : 1.0,
+        "FILTER_LENGTH"                    : 3.0


You have gotten rid of quite some redundant material parameters already. I'm guessing that also IGNORE_UNDRAINED is not used and that POROSITY is only there because the transient_Pw_line_element CheckProperties is looking at it. This CheckProperties is doing what the check of the constitutive law check should do. The specific filter law does not seem to contain POROSITY. This repeats in the material properties for the other test.

mnabideltares and others added 3 commits January 9, 2025 14:37

test cases for pressure filter are added

399a931

Added the projected gravity to the body forve vector.

f5e113b

Added a new compressibility calculator for filter calculations, which…

6ff43bf

… takes into account the projected gravity.

mnabideltares linked an issue Jan 10, 2025 that may be closed by this pull request

[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12323

Open

mnabideltares self-assigned this Jan 10, 2025

mnabideltares added 2 commits January 10, 2025 14:19

Documentation is added

4d27652

fix

5be7ec0

mnabideltares requested review from markelov208, rfaasse, avdg81 and WPK4FEM January 10, 2025 13:23

rfaasse reviewed Jan 10, 2025

View reviewed changes

Modifications based on review

55c094e

mnabideltares requested a review from rfaasse January 10, 2025 15:15

avdg81 mentioned this pull request Jan 10, 2025

[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12438

Closed

WPK4FEM reviewed Jan 13, 2025

View reviewed changes

mnabideltares added 3 commits January 13, 2025 11:48

clang format

0b630c8

Fix

af1d84d

Fixes based on review

e9ffca6

avdg81 reviewed Jan 14, 2025

View reviewed changes

mnabideltares added 2 commits January 14, 2025 12:25

Fixes based on review

007bf56

Fixes based on review

f2d2ab7

mnabideltares requested review from avdg81 and WPK4FEM January 14, 2025 12:05

WPK4FEM reviewed Jan 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12997

[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12997

mnabideltares commented Jan 10, 2025

rfaasse left a comment

rfaasse Jan 10, 2025

WPK4FEM left a comment

avdg81 left a comment

WPK4FEM left a comment

WPK4FEM Jan 14, 2025

WPK4FEM Jan 14, 2025

WPK4FEM Jan 14, 2025

		const double equivalent_radius_square = Prop[CROSS_AREA] / Globals::Pi;
		rPermeabilityMatrix(0, 0) = equivalent_radius_square * 0.125;

[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12997

Are you sure you want to change the base?

[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12997

Conversation

mnabideltares commented Jan 10, 2025

Description:

rfaasse left a comment

Choose a reason for hiding this comment

rfaasse Jan 10, 2025

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

WPK4FEM Jan 14, 2025

Choose a reason for hiding this comment

WPK4FEM Jan 14, 2025

Choose a reason for hiding this comment

WPK4FEM Jan 14, 2025

Choose a reason for hiding this comment