-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Separate header/source of Node
. Also adding more documentation
#13102
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave quite a few functions in the header.
Since we are touching the |
Something tells me it is going to crash something |
I see no problem in the refactor but I doubt that for this particular class implementing something in the cpp can lead to any improvement. They are very cheap to parse anyway. The problematic ones (the inlined) still need to remain in the header. That being said, why we want to make the node final exactly? |
📝 Description
This PR refactors the
Node
class, primarily by reorganizing the code in the header (node.h
) and implementing new functionality in the source file (node.cpp
). The changes include:Refactoring and Clean-Up:
node.h
.Move partially implementation to
node.cpp
Node
asfinal
Documentation:
🆕 Changelog
Node
asfinal