-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][VTK] make vtk default settings static #3871
Conversation
curious ! Why is this required ? |
It is helpful if you wan't to look at the defaults without/before creating an instance. tmp_default_parameters = VtkOutputProcess.default_parameters.Clone() #important to Clone so the originals do not get overwritten
tmp_default_parameters["folder_name"].SetString("Optimization_Results")
current_parameters.ValidateAndAssignDefaults(tmp_default_parameters)
vtk_io = VtkOutputProcess(model, current_parameters) Like this we do not duplicate default settings, but just reuse them from the place where they are originally defined. |
I see ... I am not against but concerned that this is not consistent with the way processes are doing right now ! |
Hm I think this might be a blocker for #3766 @armingeiser why don't you do it manually? if not user_defined_settings.Has("folder_name"):
user_defined_settings.AddEmptyValue("folder_name").SetString("Optimization_Results") This is also what I do in similar situations |
maybe also a function now that #58 is merged we can again work on the |
@philbucher of course i could do it manually, but doing this for more than one setting or even nested settings (as for GiD) is very tedious.
|
I created #3889 as suggested by @philbucher. |
do you still need the branch? |
As it is done in the GiDOutputProcess.