Fix Windows cotire build

[HubertBalcerzak]

This allows building Kratos with cotire on windows

[philbucher]

is it worth updating appveyor?
I would not touch it any more

[roigcarlo]

In any case, lets keep things consistent, its just adding a couple of lines...

[philbucher]

at the end of the build it says:

  -- Install configuration: "Debug"
  -- Deleting: D:/a/Kratos/Kratos/bin/Debug/KratosMultiphysics
  -- Deleting: D:/a/Kratos/Kratos/bin/Debug/libs

maybe thats why it cant find Kratos when trying to run the tests

[roigcarlo]

Nono, that's normal, it says that because prior to install we decided to delete the folder. Files get installed after, but at some point we also disable the messages.

The problem is that the env variables defined in the previous stage are not available here.

[philbucher]

yay it works
well, tests fail :)
maybe too slow in debug?

[philbucher]

@GuillermoCasas there is a test in the SwimmingDEM app that uses the non-standard python module mpmath. Can you please add a skiptest if this module is not available?
Thx

[roigcarlo]

Yep, to slow, so... we are a little f*****. Either we increase the runtime for the test, or we compile in Release, and the latter is not an option because then we run out of memory in the machine (cof cof @loumalouomega templates cof cof).

[philbucher]

Yep, to slow, so... we are a little f*****. Either we increase the runtime for the test, or we compile in Release, and the latter is not an option because then we run out of memory in the machine (cof cof @loumalouomega templates cof cof).

I try now without contact and in release. I mean, the problem with the templates is not precisely new...

[roigcarlo]

It runs out of memory at core level...

[philbucher]

oh ok
is this the same as #6284 ?

[roigcarlo]

Yep...

[philbucher]

@roigcarlo do you know which files are the problem?
Can we test this somehow?

[philbucher]

https://docs.microsoft.com/en-us/cpp/build/reference/o-options-optimize-code?view=vs-2019
I am not the expert but I think we could try some things...?

[philbucher]

now it is able to build and also run the tests in a decent amount of time :D

if fails overall because some tests are failing

[philbucher]

Tests are failing in
DEM @KratosMultiphysics/dem
SwimmingDEM @KratosMultiphysics/dem @GuillermoCasas
StructuralMechanics @philbucher (my test)

Please take a look and fix those tests such that we can merge this :)

[philbucher]

@loumalouomega also the contact tests seem to crash in Win

[philbucher]

@KratosMultiphysics/technical-committee just as an idea, we could for now disable the failing apps, merge this PR and then add the apps back in separate PRs
They are still ensured to compile in Win because they are in appveyor
this way this PR won't hang ...

[roigcarlo]

Agree

[philbucher]

Now it passes :D

[HubertBalcerzak]

@philbucher Is there anything still blocking this PR?

[philbucher]

To me this can/should go in now, none had any comments and the longer we wait the higher the chances are that some test will break

For the apps I disabled, the are still being compiled in Appveyor so nothing is lost on that end. We should fix the tests and add the apps back here asap though

The night CI that is failing is because there are some tests failing in the nightly suites, this is a known issue, and is being addressed constantly

Thanks for the efforts @HubertBalcerzak @roigcarlo

[roigcarlo]

@philbucher Seems that windows nightly is mandatory so we cannot merge :S

[philbucher]

Hm interesting/strange
I will check next week, probably we need to rename sth

[philbucher]

now it should work once the CI has passed

[philbucher]

yep now you can merge

[roigcarlo]

Ok let's do it

[philbucher]

🎉 🎉 🎉