Sdem/improving tests

[GuillermoCasas]

Description
I made some updates to the tests with the intention of adding them to the automatic nightly runs. Please, @philbucher , can you take a look and tell me if it is possible?

Changelog

• Removing non-standard python imports
• Making the structure of the tests a bit tidier
• Removing some deprecation warnings (there remains one but its solution is left for later)

Additional info
It will be very positive to have the tests there, since the application keeps breaking from time to time due to the sporadic use.

[philbucher]

overall it looks good to me, I added the app to the CI to check if it works (note that this will require final approval from the technical committee, but it should only be a formality here)

I saw that you are using

kratos_add_dependency(${KRATOS_SOURCE_DIR}/applications/FluidDynamicsApplication)
kratos_add_dependency(${KRATOS_SOURCE_DIR}/applications/DEMApplication)

I recommend importing these apps in your SwimmingDEMApplication.py to avoid problems related to imports. This is e.g. how er do it in the TrilinosApp, which depends on the MPICore

[philbucher]

Suggested change

from __future__ import print_function, absolute_import, division # makes KratosMultiphysics backward compatible with python 2.6 and 2.7

can be removed now, just a comment

[GuillermoCasas]

I thought so, but I have not seen it removed in most places. Perhaps this could be done all at once.

[philbucher]

neither scipy nor numpy are part of the python standard library, hence if you use this in a test and they are not available, the test will fail

Check this or this to see how I solve those problems, but it can be done in different ways too.

[GuillermoCasas]

Sure, I can do that.

[philbucher]

this is how it looks like otherwise (output of the Win CI)

Running SwimmingDEMApplication tests
Traceback (most recent call last):
  File "d:\a\Kratos\Kratos\bin\Custom\applications//SwimmingDEMApplication/tests/test_SwimmingDEMApplication.py", line 11, in <module>
    import NightTests
  File "d:\a\Kratos\Kratos\bin\Custom\applications\SwimmingDEMApplication\tests\NightTests.py", line 10, in <module>
    import TestFactory as TF
  File "d:\a\Kratos\Kratos\bin\Custom\applications\SwimmingDEMApplication\tests\TestFactory.py", line 9, in <module>
    from tests_python_scripts.candelier_scripts.candelier_analysis import CandelierBenchmarkAnalysis
  File "d:\a\Kratos\Kratos\bin\Custom\applications\SwimmingDEMApplication\tests\tests_python_scripts\candelier_scripts\candelier_analysis.py", line 10, in <module>
    import candelier
  File "d:\a\Kratos\Kratos\bin\Custom\applications\SwimmingDEMApplication\tests\tests_python_scripts\candelier_scripts\candelier.py", line 2, in <module>
    import scipy.special
ModuleNotFoundError: No module named 'scipy'
d:\a\Kratos\Kratos\bin\Custom\applications//SwimmingDEMApplication/tests/test_SwimmingDEMApplication.py

[philbucher]

cool now it works!

In order to add it to the CI the official maintainers should be know => #6412 (comment)
I guess this would be you and @maceligueta?

[GuillermoCasas]

Yes, you assume correctly.

[philbucher]

The @KratosMultiphysics/technical-committee approves adding the SwimmingDEM app to the CI

Nice work 👍