DON'T MERGE: Replacing boost for std pointers (just core, for testing) TESTS CRASH #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing: boost::shared_ptr -> std::shared_ptr boost::weak_ptr -> std::weak_ptr boost::make_shared -> std::make_shared
loumalouomega
changed the title
loumalouomega
requested review from
pooyan-dadvand,
roigcarlo,
jcotela and
RiccardoRossi
|
This is exactly the reason that we have posponed this migration to std pointer. We should wait for more stable version of boost. |
|
OK, I will remove this PR
El 31 ago. 2017 7:58 p. m., "Pooyan Dadvand" <notifications@github.com>
escribió:
… This is exactly the reason that we have posponed this migration to std
pointer. We should wait for more stable version of boost.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#742 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATEMgObtLgYg7FcIxsYSFdZ5heAddXwhks5sdvQngaJpZM4PInsS>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing (it compiles):
boost::shared_ptr -> std::shared_ptr
boost::weak_ptr -> std::weak_ptr
boost::make_shared -> std::make_shared
I have been doing some tests and the replace is right now not possible for our dependency of boost::python. The community was working on it, boostorg/python#29 and it was suposed to be solved in Boost 1.63, but I think that that version is not compatible with Kratos, right @roigcarlo?