Skip to content

Commit

Permalink
Included type hint for rank field to fix bug in generated client.
Browse files Browse the repository at this point in the history
  • Loading branch information
Kraust committed Mar 5, 2024
1 parent af8f335 commit fadca72
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v2024.2b260
v2024.3b040
2 changes: 1 addition & 1 deletion ladder/serializers/ladder_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def get_date(self, obj):
"""Return the date of the combat log"""
return obj.combatlog.metadata.date_time

def get_rank(self, obj):
def get_rank(self, obj) -> int:
"""Return the rank of the ladder entry with respect to the ladder"""
key = f"data__{obj.ladder.metric}__gte"
flt = {key: obj.data.get(obj.ladder.metric, 0)}
Expand Down

1 comment on commit fadca72

@vercel
Copy link

@vercel vercel bot commented on fadca72 Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.