Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Become compatible with React Native v0.59 #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swansontec
Copy link

React Native v0.59 uses a new version of the Android SDK that is incompatible with the one in this library, producing build failures. Using the rootProject setting means this library will automatically work with a broad range of React Native versions, so this shouldn't be a breaking change.

React Native v0.59 uses a new version of the Android SDK that is incompatible with the one in this library, producing build failures. Using the `rootProject` setting means this library will automatically work with a broad range of React Native versions, so this shouldn't be a breaking change.
Copy link

@therealravitej therealravitej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent build failures.

@loga4
Copy link

loga4 commented Jun 14, 2019

can someone to merge this PR ?

@luancurti
Copy link

luancurti commented Jun 30, 2019

Please merge this PR asap? @therealravitej @seantimm I'm getting the same error of #18 and this PR fix this

@bkspace
Copy link
Contributor

bkspace commented Jul 1, 2019

:shipit:

@DISKONEKTeD
Copy link

abandoned package?

@luancurti
Copy link

Possible workaround facebook/react-native#19239 (comment)

@markhomoki
Copy link

From RN 0.60 you can use Linking.openSettings() which does the same thing as this lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants