Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression after improving integration with Profiler, fix per page selector not working properly #137 #138

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Kreyu
Copy link
Owner

@Kreyu Kreyu commented Oct 11, 2024

Targets #137

Fixes and improves the integration with Profiler:

  • now it properly collects pagination data instead of always showing page 1 and 25 items per page
  • now it does not interfere with pagination controls nor current page results

Fixes and improves the "per page" selector:

  • now it properly displays currently selected choice
  • it does not lose other URL query parameters on change (e.g. filtration form)
  • submitting a filtration form no longer resets the per page

@Kreyu Kreyu merged commit 7e53a0c into main Oct 11, 2024
16 checks passed
@Kreyu Kreyu deleted the bugfix/137 branch October 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant