-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add @code_src #253
add @code_src #253
Conversation
Moelf
commented
Dec 7, 2021
•
edited
Loading
edited
if macro name and implementation are good with you, I will add documentation and tests @KristofferC |
Seems OK to me but I wonder a bit how useful this is in practice. By using |
I think: one might want to take screenshot with context for comparison, commentary |
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 19.28% 20.89% +1.60%
==========================================
Files 12 13 +1
Lines 866 876 +10
==========================================
+ Hits 167 183 +16
+ Misses 699 693 -6
Continue to review full report at Codecov.
|
c607ded
to
1763ffd
Compare
@KristofferC pretty sure docs build fail is unrelated |
bump |
gentle bump |
Sorry for the slow response here. I've been hardcore neglecting this package for quite a while. Looking at this with fresh eyes I don't think it really fits very well in here. And the way this is implemented by adding a whole new macro as a side effect of loading another package is quite unusual. Typically, you want to add a method extension but that is kind of hard to macros. And I also don't really want to add a dependency on Requires. |