add markdown highlighting #97
Conversation
| HIGHLIGHT_MARKDOWN = Ref(true) | ||
| enable_highlight_markdown(v::Bool) = HIGHLIGHT_MARKDOWN[] = v | ||
|
|
||
| function Base.Markdown.term(io::IO, md::Base.Markdown.Code, columns) |
There was a problem hiding this comment.
isn't this going to interfere with Documenter?
There was a problem hiding this comment.
by shadowing base code on base types
|
I guess you are saying that Documenter calls into the terminal renderer for markdown? Does it? |
|
Looks like it doesn't. The Atom or VS Code plugins might? |
|
Atom renders Markdown (in e.g. the help) using the HTML renderer and VS Code runs all their stuff in a sandboxed environment (not sure what they use). |
|
Maker.jl and Lexicon.jl appear to use |
|
Oh, the docpackage deprecated in 0.4 uses it, hmmm. As to maker, I guess it will be slightly better when used with OMR. The whole point of this package is to experiment with new behaviour.if people don't love it they can disable the feature or uninstall the package. |
|
By using this package the user says that he/she rather have the OMR defaults than the defaults in Julia. You might as well consider it a super lightweight fork of Julia but Julia is so flexible that instead of me having to ship the full Julia distribution, I can just ship the diff of my "fork" vs the Base Julia and Julia will monkey patch it in for me.
You are using quite negative words about my package that I have spent a lot of time, effort and care to implement and I have tried my best to provide a good user experience and quickly fix any problems users have had. I have also been a good boy and upstreamed many of the changes that were first tried out here in this package to Base Julia, just like you are supposed to do (package -> Base). I am tired of having these discussions every time I add a feature to this package. I know you don't like it, it has been noted but I won't be having this discussion again. |
Closes #96