RFC: Use ScopedValues.jl for TimerOutputs #169
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used TimerOutputs as place to potentially use https://github.com/vchuravy/ScopedValues.jl / JuliaLang/julia#50958
This removes the need for the user to interact directly with
TimerOutput
variables.running
f(); TimerOutputs.reset_timer()
This is largely just an experiment, and obviously very breaking.
If folks are interested in this I would be happy to cleanup the tests,
and docs.