-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EEx and EEx template parsing #923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than one line
<%% does not need to be paired with %> and all other tags work "inside" it even if it is, so it's better to not treat it as a tag, but as an escaped opening token instead.
Name subexpression of expressionRecoverWhile instead of using positional name.
Allows to handle `do %>\n <%` correctly.
Don't roll fix for missing stab in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #186
Changelog
Enhancements
.eex
as the final extension will be treated as EEx. To determine the Template Data Language, the.eex
extension will be stripped and any remaining extension will be looked up to get the File Type and its associated Language. For example,*.txt.eex
will be EEx with Plain Text (.txt
) as the Data Template Language. Likewise,*.html.eex
will be EEx with HTML as the Data Template Language. There's no need to register*.txt.eex
or*.html.eex
or any other*.DATA_TEMPLATE_LANGUAGE_EXTENSION.eex
pattern explicitly: the nested extension will be looked up using the normal extension setup.2016.2
is dropped because it's over a year old. It is still supported, but not actively tested.