Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collections deprecation warning #411

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

chrisjsewell
Copy link
Contributor

Fixes:

scss/types.py:6: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    from collections import Iterable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 66.801% when pulling 147a490 on chrisjsewell:fix-deprecate/collections into 6bf001e on Kronuz:master.

@amotoki
Copy link
Contributor

amotoki commented Mar 8, 2021

LGTM as pyScss supports python 2.7 too.

/cc @amotoki

@loic-simon
Copy link

This warning will become an error in Python 3.10, released in a few days.

Is it possible to merge this fix asap, since it use a try/except block (so no issue with 2.7) ?

/cc @e0ne

Thanks

@GammaGames
Copy link

Would be cool if this were merged and released. Can't use the library in 3.10.

@wynnw
Copy link

wynnw commented Jan 11, 2022

This hit us too. Guess we'll have to run a fork now if the project isn't putting out anymore easy updates. Looks pretty dead. (Update - python-libsass is a good alternative that doesn't have this problem)

@manchandavishal
Copy link

LGTM,
@e0ne , Could you please approve this asap and release it.
Thanks.

@e0ne e0ne merged commit bbbb398 into Kronuz:master Feb 14, 2022
@mauritsvanrees
Copy link

Fix was included in 1.4.0, released today. I don't see warning messages anymore at startup. Thanks Ivan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants