Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: KryptonTreeView Multi Node Select #215

Closed
sdreb3421 opened this issue Jul 27, 2021 · 5 comments
Closed

[Bug]: KryptonTreeView Multi Node Select #215

sdreb3421 opened this issue Jul 27, 2021 · 5 comments
Labels
bug Something isn't working completed This issue has been completed.
Milestone

Comments

@sdreb3421
Copy link

Most advanced TreeView controls in other libraries support selecting multiple nodes in the view.

This could be visually added to the existing KryptonTreeView control with a simple workaround. Currently, the control uses the palette StateChecked coloring to draw the selected node (see line 1966 of KryptonTreeView.cs). A single designer property could be added to allow drawing the StateChecked coloring if the node is either selected OR if the node is checked. Then users could use each node's checked property to visually simulate multi selection.

Alternatively, the control could be updated with true multi selection, but this would be much more difficult.

@sdreb3421 sdreb3421 added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. labels Jul 27, 2021
@Smurf-IV
Copy link
Member

My $0.02 worth:
The idea is to have the standard controls close to the originals with theming.

So that the developers can Add the extra features.
I'm in 2 minds whether this should be an addition to standard or an extension in Extended suite.

Note: The TreeGridView in the Extended suite, Version-next (V6) branch allows this.

@sdreb3421
Copy link
Author

I agree, and this change would just be a theme upgrade which gives the user the ability to show the checked state with a node color instead of a checkbox image.

@Smurf-IV Smurf-IV added the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Aug 27, 2023
@Smurf-IV Smurf-IV added under investigation This bug/issue is currently under investigation. and removed awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. labels Dec 24, 2023
@Smurf-IV Smurf-IV self-assigned this Dec 24, 2023
@Smurf-IV Smurf-IV added this to the Version 90 milestone Jan 5, 2024
@Smurf-IV
Copy link
Member

Smurf-IV commented Jan 5, 2024

Having investigated this: I think that the State###Pressed is supposed to do this, but it does not seem to be used!
image

@Wagnerp thoughts ?

  • Should this be converted to a bug ?
  • Change the name to be State####Selected and fix / implement ?

@PWagner1
Copy link
Contributor

PWagner1 commented Jan 5, 2024

@Smurf-IV Yes, will add tags now

@PWagner1 PWagner1 changed the title [Feature Request]: KryptonTreeView Multi Node Select [Bug]: KryptonTreeView Multi Node Select Jan 5, 2024
@PWagner1 PWagner1 added bug Something isn't working and removed enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. labels Jan 5, 2024
@Smurf-IV
Copy link
Member

Smurf-IV commented Jan 5, 2024

  • Designer values named State####Pressed have changed to State#####MultiSelect to reflect usage
  • New TreeView Designer value MultiSelect allows drawing of selected items and retrieval via CheckedNodes

example

Smurf-IV added a commit that referenced this issue Jan 5, 2024
…#MultiSelect` to reflect usage

- New TreeView Designer value `MultiSelect` allows drawing of selected items and retrieval via `CheckedNodes`
- Some Nullables

#215
@Smurf-IV Smurf-IV removed their assignment Jan 5, 2024
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed under investigation This bug/issue is currently under investigation. labels Jan 5, 2024
@Smurf-IV Smurf-IV closed this as completed Jan 5, 2024
Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed This issue has been completed.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants