Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: RibbonGroupNumericUpDown does not have tooltips #382

Closed
Smurf-IV opened this issue Sep 23, 2021 · 11 comments
Closed

[Bug]: RibbonGroupNumericUpDown does not have tooltips #382

Smurf-IV opened this issue Sep 23, 2021 · 11 comments
Labels
area:ribbon All issues to do with the ribbon. bug Something isn't working completed This issue has been completed.
Milestone
January 2022

Comments

@Smurf-IV
Copy link
Member

image

The GroupColourButton does :

image
@Smurf-IV Smurf-IV added bug Something isn't working area:ribbon All issues to do with the ribbon. labels Sep 23, 2021
PWagner1 added a commit that referenced this issue Sep 23, 2021
@PWagner1
* Fixed #382
4671673
@PWagner1 PWagner1 added this to the November 2021 (Version 6) milestone Sep 23, 2021
@PWagner1 PWagner1 added the fixed This issue has been fixed. label Sep 23, 2021
@PWagner1 PWagner1 mentioned this issue Sep 23, 2021
Merged
@PWagner1
Copy link
Contributor

@Smurf-IV Think I've fixed it, please check the latest PR

@Smurf-IV Smurf-IV removed the fixed This issue has been fixed. label Sep 27, 2021
@Smurf-IV
Copy link
Member Author

@Wagnerp
Reopening.
Values can be set, but tooltip does not show

@Smurf-IV Smurf-IV reopened this Sep 27, 2021
@Smurf-IV Smurf-IV self-assigned this Oct 23, 2021
@Smurf-IV Smurf-IV added the under investigation This bug/issue is currently under investigation. label Oct 23, 2021
@PWagner1 PWagner1 modified the milestones: January 2022, Future Dec 5, 2021
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Dec 5, 2021

Test that the normal KUpDowner has tips:
image

image

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Dec 5, 2021

Found #511 as part of the investigation for this

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Dec 5, 2021

@Wagnerp The fix for this will introduce a breaking change for Ribbon usages with tooltips
How are these breaking changes going to be published ?

@PWagner1
Copy link
Contributor

PWagner1 commented Dec 5, 2021

@Wagnerp The fix for this will introduce a breaking change for Ribbon usages with tooltips How are these breaking changes going to be published ?

@Smurf-IV That's fine, it could become part of a 'v7' release with .NET 7.

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Dec 5, 2021

No, I Need this fix before the end of the year !

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Dec 5, 2021

As V6 is not out of canary yet, it could still be in that !

@PWagner1
Copy link
Contributor

PWagner1 commented Dec 5, 2021

Ok, that's fine, but it does need to be clearly documented.

@PWagner1 PWagner1 modified the milestones: Future, January 2022 Dec 5, 2021
@PWagner1
Copy link
Contributor

PWagner1 commented Dec 5, 2021

@Smurf-IV Once the fix for this issue is in alpha, I may publish one last canary build for 2201, before merging alpha-build2202 & alpha together. Hope this is ok?

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Dec 6, 2021

image

image

image

image

Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Dec 6, 2021
@Smurf-IV
- Update the Usage of the tooltips to actually reflect the base of th…
d617336 
…e standard kit

for the investigations into:
Krypton-Suite/Standard-Toolkit#382
Krypton-Suite/Standard-Toolkit#511
Smurf-IV added a commit that referenced this issue Dec 6, 2021
@Smurf-IV
- Replace the scatter-gun Ribbon Tooltips with the Standard kit `Tool…
6c22ca7 
…TipValues`

- Fix fallout of the changes
- Update Readme and start to Add "Breaking Changes"
- Update Changelog
#511
#382
This was referenced Dec 6, 2021
Merged
Merged
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed under investigation This bug/issue is currently under investigation. labels Dec 6, 2021
@Smurf-IV Smurf-IV removed their assignment Dec 6, 2021
@Smurf-IV Smurf-IV closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ribbon All issues to do with the ribbon. bug Something isn't working completed This issue has been completed.
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
2 participants
@PWagner1 @Smurf-IV