Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify deal approve coin count err #102

Open
wants to merge 1 commit into
base: dex
Choose a base branch
from

Conversation

leal-liu
Copy link

@leal-liu leal-liu commented Dec 1, 2020

Summary

Introduction

modify deal approve coin count err

Modifys


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch
  • Linked to Github issue with discussion.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #102 (4749edc) into dex (8be057e) will increase coverage by 0.10%.
The diff coverage is 34.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dex     #102      +/-   ##
==========================================
+ Coverage   42.17%   42.28%   +0.10%     
==========================================
  Files         165      165              
  Lines        9666     9646      -20     
==========================================
+ Hits         4077     4079       +2     
+ Misses       5123     5099      -24     
- Partials      466      468       +2     
Impacted Files Coverage Δ
app/app.go 0.00% <0.00%> (ø)
x/distribution/client/cli/query.go 0.00% <ø> (ø)
x/distribution/client/cli/tx.go 4.10% <0.00%> (-0.66%) ⬇️
x/distribution/client/common/common.go 16.27% <0.00%> (ø)
x/distribution/keeper/fee_pool.go 0.00% <0.00%> (ø)
x/distribution/keeper/invariants.go 0.00% <0.00%> (ø)
x/distribution/keeper/querier.go 0.00% <ø> (ø)
x/distribution/keeper/store.go 46.44% <0.00%> (-0.52%) ⬇️
x/distribution/keeper/validator.go 86.04% <ø> (ø)
x/distribution/simulation/operations.go 0.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bdb1c0...4749edc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants