Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug [azure]: dns zone API requests are not sanitized to remove changing request/trace ids #223

Closed
mikenairn opened this issue Sep 9, 2024 · 0 comments · Fixed by #234
Closed
Assignees
Labels
bug Something isn't working

Comments

@mikenairn
Copy link
Member

mikenairn commented Sep 9, 2024

What

If there is an issue when listing zones the error returned is not sanitized to remove trace/request ids that change on every request. This is resulting in the error that is being added to the dnsrecord status changing on every repeated request and triggering this issue #218

Test added here should be enabled for Azure to reproduce the problem:

//Azure
Expect(testDNSProviderSecret.Type).To(Equal(v1alpha1.SecretTypeKuadrantAzure))
pBuilder.WithDataItem(v1alpha1.AzureJsonKey, "{\"tenantId\": \"1234\", \"subscriptionId\": \"1234\", \"resourceGroup\": \"foobar\", \"aadClientId\": \"1234\", \"aadClientSecret\": \"1234\"}")
expectedProviderErr = "ClientSecretCredential: unable to resolve an endpoint"
@mikenairn mikenairn added the bug Something isn't working label Sep 9, 2024
@philbrookes philbrookes moved this to Todo in Kuadrant Sep 9, 2024
@mikenairn mikenairn changed the title azure: dns zone API requests are not sanitized to remove changing request/trace ids bug [azure]: dns zone API requests are not sanitized to remove changing request/trace ids Sep 9, 2024
@philbrookes philbrookes mentioned this issue Sep 12, 2024
7 tasks
philbrookes added a commit to philbrookes/dns-operator that referenced this issue Sep 16, 2024
philbrookes added a commit to philbrookes/dns-operator that referenced this issue Sep 16, 2024
Signed-off-by: Phil Brookes <pbrookes@redhat.com>
philbrookes added a commit to philbrookes/dns-operator that referenced this issue Sep 16, 2024
Signed-off-by: Phil Brookes <pbrookes@redhat.com>
philbrookes added a commit to philbrookes/dns-operator that referenced this issue Sep 16, 2024
Signed-off-by: Phil Brookes <pbrookes@redhat.com>
philbrookes added a commit to philbrookes/dns-operator that referenced this issue Sep 17, 2024
Signed-off-by: Phil Brookes <pbrookes@redhat.com>
github-merge-queue bot pushed a commit that referenced this issue Sep 18, 2024
gh-223: sanitize all Azure API errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants