tests: Use unique zone hostnames for each integration test #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration test suite uses the inmemory provider which is shared across all test specs. This works fine if a record is created and deleted successfully very quickly as the records in the provider will be removed, but if for any reason they aren't (secret gets removed before the record has completed its deletion reconcile for instance) they can be left behind and cause odd issues with other tests that are using the same hostname. The changes here update the integration test suite to: * Use a generated zone/hostname unique for each single test, this is similar in approach to the current e2e tests. * Remove all cleanup logic from the integration test suite for record and secrets(providers). Alternative would be to wait for each deletion to complete before allowing it to continue but this could add significant amount of time to each test for little gain. Tests that explicitly test the deletion logic already exist in the integration and e2e suits. Signed-off-by: Michael Nairn <mnairn@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration test suite uses the inmemory provider which is shared across all test specs. This works fine if a record is created and deleted successfully very quickly as the records in the provider(memory) will be removed, but if for any reason they aren't (secret gets removed before the record has completed its deletion reconcile for instance) they can be left behind and cause odd issues with other tests that are using the same hostname.
The changes here update the integration test suite to: