Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowered limit for AuthPolicy rules section #566

Closed
azgabur opened this issue Apr 23, 2024 · 5 comments · Fixed by #1019
Closed

Lowered limit for AuthPolicy rules section #566

azgabur opened this issue Apr 23, 2024 · 5 comments · Fixed by #1019
Assignees
Labels
kind/bug Something isn't working

Comments

@azgabur
Copy link

azgabur commented Apr 23, 2024

Due to #525 the limit for AuthPolicy rules section is now 10. This number is relatively low and has also not been officially documented. Some teams utilizing Authorino have implemented AuthConfig with up to 14 rules so I think this limit should be raised back.

The discussion slack link:
https://kubernetes.slack.com/archives/C05J0D0V525/p1713781063062309?thread_ts=1713343676.107059&cid=C05J0D0V525

@guicassolato
Copy link
Contributor

I expect this to be solved as part of removing the routeSelectors in favour of targetRef.sectionName (#809).

Hopefully this will decrease the complexity level of the API validation, thus allowing more rules into the budget.

@guicassolato
Copy link
Contributor

Fixed in #924

@jsmolar
Copy link

jsmolar commented Nov 13, 2024

@guicassolato I am still seeing this in RC4
Image

@jsmolar jsmolar reopened this Nov 13, 2024
@Boomatang
Copy link
Contributor

This regression was caused by the reintroducing the of the CEL validation in #952. It is unclear if this was accidental. The PR has no mention of reverting this.

Link to cause: https://github.com/Kuadrant/kuadrant-operator/pull/952/files#diff-48be39356f46d89e1b8760a8b146fd7cc46946e2ae2bdf7bdc4ee5b01e9bef95R406-R407

@jsmolar jsmolar moved this from Done to Todo in Kuadrant Nov 13, 2024
@guicassolato
Copy link
Contributor

I had removed it. I guess it was added back during a rebasing. It's a bug.

@Boomatang Boomatang moved this to Ready For Review in Kuadrant Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants